issues

Table actions

4 rows where comments = 11, type = "pull" and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 4 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2034575163 PR_kwDOAMm_X85hn4Pn 8539 Filter out doctest warning max-sixty 5635139 closed 0     11 2023-12-10T23:11:36Z 2023-12-12T06:37:54Z 2023-12-11T21:00:01Z MEMBER   0 pydata/xarray/pulls/8539

Trying to fix #8537. Not sure it'll work and can't test locally so seeing if it passes CI

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8539/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
515662368 MDExOlB1bGxSZXF1ZXN0MzM1MDg1NTM4 3475 drop_vars; deprecate drop for variables max-sixty 5635139 closed 0     11 2019-10-31T18:46:48Z 2019-11-07T23:20:40Z 2019-11-07T20:13:51Z MEMBER   0 pydata/xarray/pulls/3475

Introduces drop_vars, and deprecates using drop for variables. drop is widely used for the deprecated case, so this is a fairly wide blast radius.

It's more churn than is ideal, but I do think it's a much better API.

This is ready for review, though I'm sure I'm missed references in the docs etc (took my peak regex skills to find/replace only the deprecated usages!)

Originally discussed here

  • [x] Tests added
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3475/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
469871658 MDExOlB1bGxSZXF1ZXN0Mjk4OTk4MTE2 3142 Black max-sixty 5635139 closed 0     11 2019-07-18T16:35:05Z 2019-08-08T20:55:14Z 2019-08-08T20:54:34Z MEMBER   0 pydata/xarray/pulls/3142

From https://github.com/pydata/xarray/issues/3092

  • [x] Reformat code
  • [x] CI checks
  • [x] Short instructions for how to merge an existing PR (i.e. avoid manual merge resolution)
  • Not sure if there's magic here - I think people would just have to format their code and then hope git can resolve (i.e. because there would still be no common parent)?
  • [x] Black badge
  • [x] Do we want to keep flake8 checks? Black is mostly stricter but not always, e.g. on lines at the end of files. (+0.3 from me to use only black and stop using flake8)

~- [ ] Do we want to include isort? (-0.1 from me, even though I like the tool)~

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3142/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
121601010 MDExOlB1bGxSZXF1ZXN0NTMzMzI4MDY= 677 Dataset constructor can take pandas objects max-sixty 5635139 closed 0     11 2015-12-10T23:22:32Z 2016-01-02T07:44:26Z 2016-01-02T07:34:50Z MEMBER   0 pydata/xarray/pulls/677

Closes a 'first-step' of https://github.com/xray/xray/issues/676. Works only for simple, non-MultiIndexed, pandas objects. 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/677/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);