issues

Table actions

4 rows where comments = 10, state = "closed" and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date), closed_at (date)

type 2

state 1

  • closed · 4 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1874695065 I_kwDOAMm_X85vvZOZ 8125 failing tests with pandas 2.1 dcherian 2448579 closed 0     10 2023-08-31T02:42:32Z 2023-09-15T13:12:02Z 2023-09-15T13:12:02Z MEMBER      

What happened?

See https://github.com/pydata/xarray/pull/8101

FAILED xarray/tests/test_missing.py::test_interpolate_pd_compat - ValueError: 'fill_value' is not a valid keyword for DataFrame.interpolate FAILED xarray/tests/test_missing.py::test_interpolate_pd_compat_non_uniform_index - ValueError: 'fill_value' is not a valid keyword for DataFrame.interpolate

and this doctest FAILED xarray/core/dataarray.py::xarray.core.dataarray.DataArray.to_unstacked_dataset @pydata/xarray can someone take a look please?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8125/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed xarray 13221727 issue
684930038 MDU6SXNzdWU2ODQ5MzAwMzg= 4372 Set `allow_rechunk=True` in `apply_ufunc` dcherian 2448579 closed 0     10 2020-08-24T20:02:50Z 2020-09-09T19:00:17Z 2020-09-09T19:00:17Z MEMBER      

What happened:

blockwise calls unify_chunks by default but apply_gufunc does not; so we have a regression in apply_ufunc now that we've switched from blockwise to apply_gufunc.

Minimal Complete Verifiable Example:

```python import operator

a = xr.DataArray(np.arange(10), dims=("a")).chunk({"a": 2}) b = xr.DataArray(np.arange(10), dims=("a")).chunk({"a": 4})

xr.apply_ufunc(operator.add, a, b, dask="parallelized", output_dtypes=[a.dtype]).compute() ```

raises ValueError: Dimension `'__loopdim0__'` with different chunksize present

on master but works with 0.16.0

I think we need to do dask_gufunc_kwargs.setdefault("allow_rechunk", True)

If we want to avoid that, we'll need to go through a deprecation cycle.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4372/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed xarray 13221727 issue
444520875 MDExOlB1bGxSZXF1ZXN0Mjc5MTY0MTQ2 2965 Don't set encoding attributes on bounds variables. dcherian 2448579 closed 0     10 2019-05-15T16:00:44Z 2019-06-25T00:24:46Z 2019-06-25T00:24:42Z MEMBER   0 pydata/xarray/pulls/2965

Here's a proposed fix for #2436 and #2921. Ping @spencerkclark @mathause @klindsay28

  1. Removes certain attributes from bounds variables on encode.

  2. open_mfdataset: Sets encoding on variables based on encoding in first file.

  3. [x] Closes #2921

  4. [x] Tests added
  5. [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2965/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
298481284 MDExOlB1bGxSZXF1ZXN0MTcwMTA4MjE1 1926 Add x,y kwargs for plot.line(). dcherian 2448579 closed 0     10 2018-02-20T06:04:35Z 2018-05-10T05:12:03Z 2018-03-05T22:14:46Z MEMBER   0 pydata/xarray/pulls/1926
  • [x] Partially closes #575
  • [x] Tests added
  • [x] Tests passed
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Description

plot.line now supports both 1D and 2D DataArrays as input. I've changed some variable names to make code clearer: 1. set xplt, yplt to be values that are passed to ax.plot() 2. xlabel, ylabel are axes labels 3. xdim, ydim are dimension names

Example

This code ```z = np.arange(10) da = xr.DataArray(np.cos(z), dims=['z'], coords=[z], name='f')

xy = [[None, None], [None, 'f'], [None, 'z'], ['f', None], ['z', None], ['z', 'f'], ['f', 'z']]

f, ax = plt.subplots(2,4)

for aa, (x,y) in enumerate(xy): da.plot(x=x, y=y, ax=ax.flat[aa]) ax.flat[aa].set_title('x='+str(x)+ ' | '+'y='+str(y)) ```

yields

Feedback requested

Should I refactor out the kwarg checking? 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1926/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);