issues: 965939431

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
965939431 MDExOlB1bGxSZXF1ZXN0NzA4MjIwNDIy 5690 Change annotations to allow str keys 5635139 closed 0     4 2021-08-11T05:17:02Z 2021-08-19T17:55:49Z 2021-08-19T17:27:01Z MEMBER   0 pydata/xarray/pulls/5690
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

IIUC: - This test below would fail mypy because the key of Mapping is invariant (though Any still lets anything through) - I've only seen this when the dict is defined in a different expression from the Dataset constructor - Mypy doesn't type-check our test functions, because the functions don't have any annotations.

If that's correct, we should change all our Mapping to use Any rather than Hashable, and add type annotations to our test functions (even just -> None)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5690/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables