issues: 948890466
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
948890466 | MDExOlB1bGxSZXF1ZXN0NjkzNjY1NDEy | 5624 | Make typing-extensions optional | 1217238 | closed | 0 | 6 | 2021-07-20T17:43:22Z | 2021-07-22T23:30:49Z | 2021-07-22T23:02:03Z | MEMBER | 0 | pydata/xarray/pulls/5624 | Type checking may be a little worse if typing-extensions are not installed, but I don't think it's worth the trouble of adding another hard dependency just for one use for TypeGuard. Note: sadly this doesn't work yet. Mypy (and pylance) don't like the type alias defined with try/except. Any ideas? In the worst case, we could revert the TypeGuard entirely, but that would be a shame...
|
{ "url": "https://api.github.com/repos/pydata/xarray/issues/5624/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |