issues: 932393011

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
932393011 MDExOlB1bGxSZXF1ZXN0Njc5NzQyODk1 5548 Fix 2 type annotations in dataarray.py 28426758 closed 0     2 2021-06-29T09:03:23Z 2021-06-29T19:15:33Z 2021-06-29T18:51:19Z CONTRIBUTOR   0 pydata/xarray/pulls/5548

Both set_index and reset_index are wrappers to other methods that return "DataArray", not Optional["DataArray"]. That is, they will never return None. That's why these methods should also have only "DataArray" in there return signature. This way it will be possible to do something like myarray = myarray.reset_index(...) without getting a complaint from Mypy.

For extended discussion, see https://github.com/pydata/xarray/issues/5533#issuecomment-869822366

  • [x] Closes #5533
  • [ ] Tests added
  • [ ] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5548/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables