issues: 930918574

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
930918574 MDExOlB1bGxSZXF1ZXN0Njc4NTA3NDMw 5540 Cache some properties 14371165 open 0     4 2021-06-27T12:22:16Z 2022-07-10T14:34:34Z   MEMBER   1 pydata/xarray/pulls/5540

Cache some small properties that are rather slow to calculate but doesn't change that often.

Questions that needs to be resolved:

  • [ ] Can these properties change during the lifetime of the class? If so the cache needs to be reset when that happens.
  • [ ] Related to #3514
  • [ ] Tests added
  • [ ] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

Notes * Mixin classes makes it difficult to cache properties. For example ndim in NdimSizeLenMixin cannot be easily be replaced with cache_readonly.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5540/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables