issues: 928490583

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
928490583 MDExOlB1bGxSZXF1ZXN0Njc2NDg2ODM0 5519 Type hints for combine functions 35968931 closed 0     4 2021-06-23T17:33:36Z 2021-09-30T20:16:45Z 2021-09-30T19:52:47Z MEMBER   0 pydata/xarray/pulls/5519

Added type hints to combine_nested and combine_by_coords.

Builds on #4696 because that PR generalised the argument types to include DataArrays, but I couldn't see that branch in the list to base this PR off of.

The "nested list-of-lists" argument to combine_nested opens up a can of worms: the only way I can see to specify the type of a nested list of arbitrary depth is to define the type recursively, but mypy does not currently support recursive type definitions, though some other type checkers can, e.g. Microsoft's Pylance does. We're going to have the same problem when specifying types for open_mfdataset. For now this problem is just ignored by the type checker, meaning that we don't actually check the type of the nested-list-of-lists.

  • [x] Passes pre-commit run --all-files
  • [ ] ~~User visible changes (including notable bug fixes) are documented in whats-new.rst~~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5519/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables