issues: 906023492

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
906023492 MDExOlB1bGxSZXF1ZXN0NjU3MDYxODI5 5400 Multidimensional histogram 35968931 open 0     3 2021-05-28T20:38:53Z 2022-11-21T22:41:01Z   MEMBER   0 pydata/xarray/pulls/5400

Initial work on integrating the multi-dimensional dask-powered histogram functionality from xhistogram into xarray. Just working on the skeleton to fit around the histogram algorithm for now, to be filled in later.

  • [x] Closes #4610
  • [x] API skeleton
  • [x] Input checking
  • [ ] Internal blockwise algorithm from https://github.com/xgcm/xhistogram/pull/49
  • [x] Redirect plot.hist
  • [x] da.weighted().hist()
  • [ ] Tests added for results
  • [x] Hypothesis tests for different chunking patterns
  • [ ] Examples in documentation
  • [ ] Examples in docstrings
  • [x] Type hints (first time trying these so might be wrong)
  • [ ] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
  • [x] Range argument
  • [ ] Handle multidimensional bins (for a future PR? - See https://github.com/xgcm/xhistogram/pull/59)
  • [ ] Handle np.datetime64 dtypes by refactoring to use np.searchsorted (for a future PR? See discussion)
  • [ ] Fast path for uniform bin widths (for a future PR? See suggestion)

Question: da.hist() or da.histogram()?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5400/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables