issues: 897953514

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
897953514 MDExOlB1bGxSZXF1ZXN0NjQ5ODg3Mzgw 5359 Make `kind` argument in `CFTimeIndex._maybe_cast_slice_bound` optional 6628425 closed 0     2 2021-05-21T11:25:46Z 2021-05-23T09:47:03Z 2021-05-23T00:13:20Z MEMBER   0 pydata/xarray/pulls/5359

Pandas recently deprecated the kind argument in Index._maybe_cast_slice_bound, and removed its use in several internal calls: https://github.com/pandas-dev/pandas/pull/41378. This led to some errors in the CFTimeIndex tests in our upstream build. We never made use of it in CFTimeIndex._maybe_cast_slice_bound so the simplest fix for backwards compatibility seems to be to make it optional for now -- in previous versions of pandas it was required -- and remove it when our minimum version of pandas is at least 1.3.0.

  • [x] Closes #5356
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5359/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables