issues: 895978572

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
895978572 MDExOlB1bGxSZXF1ZXN0NjQ4MTMxMjg3 5350 Add dask stack tests 5635139 closed 0     1 2021-05-19T22:05:46Z 2021-05-22T00:30:48Z 2021-05-22T00:30:46Z MEMBER   0 pydata/xarray/pulls/5350
  • [x] Tests added
  • [x] Passes pre-commit run --all-files

I think we could consider gradually moving to this fixture model of tests, where we pass da and it's paramaterized across dask / numpy (and anything we choose to add in the future). And it's possible to select the backing array type like selecting any other fixture type.

The general proposal probably needs some socializing and refinement before we start applying it more broadly. I'd be keen to pursue it if others agree — it could bring some more robustness to our testing suite while also making it simpler.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5350/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables