issues: 890573049

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
890573049 MDExOlB1bGxSZXF1ZXN0NjQzNTc1Mjc5 5296 More robust guess_can_open for netCDF4/scipy/h5netcdf entrypoints 1217238 closed 0     1 2021-05-12T23:53:32Z 2021-05-14T22:40:14Z 2021-05-14T22:40:14Z MEMBER   0 pydata/xarray/pulls/5296

The new version checks magic numbers in files on disk, not just already open file objects.

I've also added a bunch of unit-tests.

Fixes GH5295

  • [x] Closes #5295
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5296/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables