issues: 877166445

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
877166445 MDExOlB1bGxSZXF1ZXN0NjMxMTcwNzI4 5265 Warn ignored keep attrs 10194086 closed 0     1 2021-05-06T07:20:16Z 2021-10-18T14:06:37Z 2021-05-06T16:31:05Z MEMBER   0 pydata/xarray/pulls/5265
  • [x] Part of #4513
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

This PR warns when passing keep_attrs to resample(..., keep_attrs=True) and rolling_exp(..., keep_attrs=True) as they have no effect (rightfully). Also removes keep_attrs from the docstring of resample.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5265/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables