issues: 849315490

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
849315490 MDExOlB1bGxSZXF1ZXN0NjA4MTEwNjI0 5102 Flexible indexes: add Index base class and xindexes properties 4160723 closed 0     10 2021-04-02T16:18:07Z 2022-03-29T07:10:07Z 2021-05-11T08:21:26Z MEMBER   0 pydata/xarray/pulls/5102

This PR clears up the path for flexible indexes:

  • it adds a new ~~IndexAdapter~~ Index base class that is meant to be inherited by all xarray-compatible indexes (built-in or 3rd-party)
  • PandasIndexAdapter now inherits from ~~IndexAdapter~~ Index
  • the xarray_obj.xindexes properties return Index (PandasIndexAdapter) instances. xarray_obj.indexes properties still return pandas.Index instances.

~~The latter is a breaking change, although I'm not sure if the indexes property has been made public yet.~~

This is still work in progress, there are many broken tests that are not fixed yet. (EDIT: all tests should be fixed now).

There's a lot of dirty fixes to avoid circular dependencies and in the many places where we still need direct access to the pandas.Index objects, but I'd expect that these will be cleaned-up further in the refactoring.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5102/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables