home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 834380377

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
834380377 MDExOlB1bGxSZXF1ZXN0NTk1MjA1ODQy 5050 BUG: Future time decoding 23625371 closed 0     3 2021-03-18T04:31:31Z 2021-03-18T14:04:09Z 2021-03-18T14:03:59Z CONTRIBUTOR   0 pydata/xarray/pulls/5050
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

This identifies (and hopefully soon fixes) an issue with decoding times that are way into the future. Without re-introducing a change made in #4684, the test fails (see https://github.com/pydata/xarray/pull/5050/checks?check_run_id=2136824754). With the change put back in, the test passes (see https://github.com/pydata/xarray/pull/5050/checks?check_run_id=2136892412).

@spencerkclark can I ask for your help on this one please? It seems that the removal in #4684 caused this case (which wasn't tested) to break in v0.17 and it's unclear to me where the fix should be (I'm guessing pandas from the discussions in #4684...).

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5050/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 3 rows from issue in issue_comments
Powered by Datasette · Queries took 2.581ms · About: xarray-datasette