issues: 812655506

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
812655506 MDExOlB1bGxSZXF1ZXN0NTc2OTY5NTU1 4933 FIX: decode/encode `time_reference` 5821660 closed 0     3 2021-02-20T16:28:38Z 2023-05-25T07:19:49Z 2021-02-21T08:31:22Z MEMBER   0 pydata/xarray/pulls/4933

This is a fix for #4927.

  • time_reference is overwritten with the actual time string inside time_reference before decoding, but only if a variable with the name exists.
  • time_reference name is kept in encoding (the name might change, eg. reference_time).
  • time_reference is added back to units attribute when encoding, to make roundtrips possible.
  • [x] Closes #4927
  • [x] Tests added
  • [ ] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4933/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables