home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 787732195

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
787732195 MDExOlB1bGxSZXF1ZXN0NTU2MzY2NTcx 4820 Add dataset line plot 14371165 open 0     10 2021-01-17T15:40:39Z 2022-06-09T14:50:17Z   MEMBER   1 pydata/xarray/pulls/4820
  • [x] Closes #4235
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

TODO: * markersize/linewidth should work, easy if linewidth is only defined. But the hue/linewidth combo is trickier. * Possible, see post further down for details. Should be done in dataarray version in a future PR. * hue only works with coordinates. Should it work with variables? How to do that? groupby? * Leave it for coordinates only for now. * Should lines always be sorted to avoid weird lines? * Handled in dataarray version * linewidth not shown anywhere * line plots doesn't have the nice legend_elements function that scatter has which makes it a little bit more tricky. It can still be shown in the legend though.

Adds ds.plot.line. The function wraps ax.plot which should feel pretty homely for most matplotlib users.

It was a mess getting the colorbar to work because scatter returns a mappable that colorbar can handle but plot returns a list of line2ds that it can't handle. You also can't add cmaps directly to ax.plot, so to avoid for loops I changed the default color settings instead.

Feel free to break it.

Example:

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4820/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 10 rows from issue in issue_comments
Powered by Datasette · Queries took 2.112ms · About: xarray-datasette