issues: 780955224

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
780955224 MDExOlB1bGxSZXF1ZXN0NTUwNzYyNjMx 4774 improve typing of OrderedSet 32801740 closed 0     1 2021-01-07T01:20:56Z 2021-01-07T23:28:53Z 2021-01-07T23:28:48Z CONTRIBUTOR   0 pydata/xarray/pulls/4774
  • [x] Passes isort . && black . && mypy . && flake8

Small patch to improve typing of OrderedSet: allowing more general input type in its constructor and .update method (Iterator instead of AbstractSet) helps to get rid of # type: ignore.

Side-effect: some performance gain in micro-benchmark (before and after): %timeit xr.core.utils.OrderedSet(range(10)) 3.46 µs ± 5.37 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each) 2.06 µs ± 6.39 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4774/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables