issues: 778022297

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
778022297 MDExOlB1bGxSZXF1ZXN0NTQ4MTg2MzYw 4759 coords: retain str dtype 10194086 closed 0     1 2021-01-04T11:17:53Z 2021-01-13T17:18:28Z 2021-01-13T17:09:06Z MEMBER   0 pydata/xarray/pulls/4759
  • [x] Closes #2658, closes #4543
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

pd.Index("a") has dtype object. Therefore string coords change their dtype on certain operations - e.g. align, __setitem__ (& assign), IndexVariable.concat. This can be avoided by using the coords instead of the index in some cases but in two instances it was unavoidable to cast a pd.Index back to a np.array. I probably did not catch all of these conversions.

What I am not sure: does this somehow contradict the index refactor?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4759/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables