issues: 777751284

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
777751284 MDExOlB1bGxSZXF1ZXN0NTQ3OTYxNzk1 4758 Ensure maximum accuracy when encoding and decoding cftime.datetime values 6628425 closed 0     1 2021-01-04T00:47:32Z 2021-02-10T21:52:16Z 2021-02-10T21:44:26Z MEMBER   0 pydata/xarray/pulls/4758
  • [x] Closes #4097
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

Following up on #4684, this PR makes changes to our encoding / decoding process such that cftime.datetime objects can be roundtripped exactly. In the process, because it made the tests cleaner to define, I added cftime offsets for millisecond and microsecond frequency as well.

As I note in the what's new, exact roundtripping requires cftime of at least version 1.4.1, which included improvements to cftime.num2date (https://github.com/Unidata/cftime/pull/176, https://github.com/Unidata/cftime/pull/188) and cftime.date2num (https://github.com/Unidata/cftime/pull/178, https://github.com/Unidata/cftime/pull/225).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4758/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables