home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 772346218

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
772346218 MDExOlB1bGxSZXF1ZXN0NTQzNjI4Nzkw 4719 Remove close_on_error store.py 35919497 closed 0     1 2020-12-21T17:34:23Z 2021-02-11T01:56:13Z 2020-12-22T14:31:05Z COLLABORATOR   0 pydata/xarray/pulls/4719

Remove close_on_error in store.py. This change involves only apiv2. Currently, api_v2.open_dataset can take in input a store instead of a file. In case of error, xarray closes the store. Xarray should manage the closure of a store that has been instantiated externally. This PR correct this behaviour in apiv2

  • [x] Related https://github.com/pydata/xarray/pull/4673
  • [x] Passes isort . && black . && mypy . && flake8
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4719/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 2 rows from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 0.632ms · About: xarray-datasette