issues: 748379763

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
748379763 MDExOlB1bGxSZXF1ZXN0NTI1Mzc4Mjg5 4600 plot tests: ensure all figures are closed 24938400 closed 0     16 2020-11-22T23:45:04Z 2020-11-27T12:03:15Z 2020-11-27T10:18:38Z CONTRIBUTOR   0 pydata/xarray/pulls/4600

Test testxyincrease_false_changes_axes is flaky in nature.

TestCase passes consistently in the actual order with command: pytest tests/test_plot.py

TestCase fails when one randomises the order in test_plot.py module by using the plugin pytest-random-order with command: pytest tests/test_plot.py --random-order-seed=802425 -v

The victim test_xyincrease_false_changes_axes fails in a failing test order because there is at least one test that runs before the victim and “pollute” the state (e.g., global state: here, it is matplotlib's plt) on which the victim depends. (Paper)

After investigation, we found the polluter test to be test_ylim_kwarg

Potential Fix: Adding a plt.clf or plt.cla at the end of the polluter test. Let us know your preference.

Please let us know if you require the pass and fail logs.

Also, if one runs test_plot.py in any random order, Teardown phase throws an error which is raised by test_all_figures_closed(). Should I raise a separate PR for the same?

Contributors: Yash Saboo Nirupam K N

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4600/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables