issues: 716644871

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
716644871 MDExOlB1bGxSZXF1ZXN0NDk5MzQ1NjQw 4494 Remove maybe chunck duplicated function 35919497 closed 0     1 2020-10-07T15:42:35Z 2020-12-10T10:27:34Z 2020-10-08T15:10:46Z COLLABORATOR   0 pydata/xarray/pulls/4494

I propose this small change with a view to unifying in open_dataset the logic of zarr chunking with that of the other backends. Currently, the function maybe_chunk is duplicated: it is defined inside the function dataset.chunks and as method of zarr.ZarrStore. This last function has been added with the recent merge of #4187 . I merged the two functions in a private function _maybe_chunk inside the module dataset.

  • [x] Addresses #4309
  • [ ] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4494/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables