issues: 709195443

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
709195443 MDExOlB1bGxSZXF1ZXN0NDkzMjk5OTI4 4462 Cleanup logic inside `open_dataset`, mostly `extra_kwargs` 226037 closed 0     0 2020-09-25T18:30:28Z 2020-12-10T10:31:02Z 2020-10-08T15:06:37Z MEMBER   0 pydata/xarray/pulls/4462

This is a small, pure code-refactor PR that removes some of the cruft left in open_dataset from #4187 and #4431

  • [x] Additional clean ups after #4431
  • [x] Pure code refactor, no change in tests
  • [x] Passes isort . && black . && mypy . && flake8

Note that mode="r" is the default in open_group.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4462/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables