issues: 708766975

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
708766975 MDExOlB1bGxSZXF1ZXN0NDkyOTMxMzk3 4458 Autodetect the engine only when `engine=None` 226037 closed 0     2 2020-09-25T08:53:27Z 2020-12-10T10:30:56Z 2020-09-28T15:42:01Z MEMBER   0 pydata/xarray/pulls/4458

Always use the engine explicitly selected by the user and perform auto detection only when engine=None.

  • [x] Closes #4457
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] No new functions/methods

The refactor complexity stems mostly from moving or duplicating some logic from _get_engine_from_magic_number to the backend stores. The current, rather ugly, code minimizes changes to the error conditions and messages.

Later in the backend refactor the plugins will provide the functionalities to identify the format from the file content and the duplication should be eliminated.

@jhamman do you think I need to acknowledge the CZI sponsorship in the changelog?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4458/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables