issues: 704668670

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
704668670 MDExOlB1bGxSZXF1ZXN0NDg5NTQ5MzIx 4438 Fixed dask.optimize on datasets 1312546 closed 0     3 2020-09-18T21:30:17Z 2020-09-20T05:21:58Z 2020-09-20T05:21:58Z MEMBER   0 pydata/xarray/pulls/4438

Another attempt to fix #3698. The issue with my fix in is that we hit Variable._dask_finalize in both dask.optimize and dask.persist. We want to do the culling of unnecessary tasks (test_persist_Dataset) but only in the persist case, not optimize (test_optimize).

  • [x] Closes #3698
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4438/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables