issues: 700839138

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
700839138 MDExOlB1bGxSZXF1ZXN0NDg2Mzk2NjMz 4419 preserve original dimension, coordinate and variable order in ``concat`` 5821660 closed 0     3 2020-09-14T07:13:33Z 2022-10-09T13:05:14Z 2020-09-19T03:01:28Z MEMBER   0 pydata/xarray/pulls/4419

The problem is that the result_vars-dict is filled in two separate loops, handling variables and coordinates (AFAICT). This can change the ordering of dimensions and coordinates depending over which dimensions is concatenated.

This fix hooks into the second loop and reinsert the variable in question at the appropriate position by popping it out of the result_vars. There might be a more elegant solution to this.

  • [x] Closes #2811, closes #4072
  • [x] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4419/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables