issues: 700590739

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
700590739 MDExOlB1bGxSZXF1ZXN0NDg2MTk3NTI0 4418 Add try/except logic to handle renaming of cftime datetime base class 6628425 closed 0     1 2020-09-13T15:25:53Z 2020-09-19T13:30:02Z 2020-09-19T13:29:14Z MEMBER   0 pydata/xarray/pulls/4418

cftime is planning on renaming the base class for its datetime objects from cftime.datetime to cftime.datetime_base. See discussion in https://github.com/Unidata/cftime/issues/198 and https://github.com/Unidata/cftime/pull/199. This PR adds the appropriate logic in xarray to handle this in a backwards-compatible way.

In the documentation in places where we refer to :py:class:`cftime.datetime` objects, I have modified things to read ``cftime`` datetime. Being more generic is probably better in any case, as in most instances we do not explicitly mean that the base class can be used, only subclasses of the base class.

cc: @jswhit

  • [x] Passes isort . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4418/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables