issues: 673061269

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
673061269 MDExOlB1bGxSZXF1ZXN0NDYyOTkwNzg1 4310 Remove all unused and warn-raising methods from AbstractDataStore 226037 closed 0     1 2020-08-04T20:27:57Z 2020-09-22T21:12:47Z 2020-08-05T14:27:51Z MEMBER   0 pydata/xarray/pulls/4310
  • [x] Related but really orthogonal to #4309
  • [x] Remove code, but keeps all existing tests passing (on MacOS with pandas=1.0.5)
  • [x] Passes isort . && black . && mypy . && flake8
  • [x] No user / developer visible changes are expected

@shoyer this could be the first pass of the simplification of the current backend API. It not needed for #4309, but it make more obvious that we'd be free to keep the AbstractDataStore class if we wanted to.

The reason the change can be considered reasonably innocuous is that warnings would have been printed on access to any of the removed methods, but you never know. Your call (but I'd love to have a delete-only contribution to xarray :D).

Please note that: 1. this change is the absolute lowest hanging fruit, 2. removing __enter__ and __exit__ appears feasible as they are used only in tests, but it is a slightly bigger change, 3. removing load is marginally more complex because it handle the special case when a variable name is equal to None.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4310/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables