issues: 655389649

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
655389649 MDExOlB1bGxSZXF1ZXN0NDQ3ODkyNjE3 4219 nd-rolling 6815844 closed 0     16 2020-07-12T12:19:19Z 2020-08-08T07:23:51Z 2020-08-08T04:16:27Z MEMBER   0 pydata/xarray/pulls/4219
  • [x] Closes #4196
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

I noticed that the implementation of nd-rolling is straightforward. The core part is implemented but I am wondering what the best API is, with keeping it backward-compatible.

Obviously, it is basically should look like python da.rolling(x=3, y=3).mean()

A problem is other parameters, centers and min_periods. In principle, they can depend on dimension. For example, we can have center=True only for x but not for y.

So, maybe we allow dictionary for them? python da.rolling(x=3, y=3, center={'x': True, 'y': False}, min_periods={'x': 1, 'y': None}).mean()

The same thing happens for .construct method. python da.rolling(x=3, y=3).construct(x='x_window', y='y_window', stride={'x': 2, 'y': 1}) I'm afraid if this dictionary argument was a bit too redundant.

Does anyone have another idea?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4219/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables