issues: 646073396

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
646073396 MDExOlB1bGxSZXF1ZXN0NDQwNDMxNjk5 4184 Improve the speed of from_dataframe with a MultiIndex (by 40x!) 1217238 closed 0     1 2020-06-26T07:39:14Z 2020-07-02T20:39:02Z 2020-07-02T20:39:02Z MEMBER   0 pydata/xarray/pulls/4184

Before:

pandas.MultiIndexSeries.time_to_xarray
======= ========= ==========
--             subset
------- --------------------
dtype     True     False
======= ========= ==========
  int    505±0ms   37.1±0ms
 float   485±0ms   38.3±0ms
======= ========= ==========

After:

pandas.MultiIndexSeries.time_to_xarray
======= ============ ==========
--               subset
------- -----------------------
dtype      True       False
======= ============ ==========
  int    10.7±0.4ms   22.6±1ms
 float   10.0±0.8ms   21.1±1ms
======= ============ ==========

~~There are still some cases where we have to fall back to the existing slow implementation, but hopefully they should now be relatively rare.~~ Edit: now we always use the new implementation

  • [x] Closes #2459, closes #4186
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] Passes isort -rc . && black . && mypy . && flake8
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4184/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     13221727 pull

Links from other tables