issues: 626215981

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
626215981 MDExOlB1bGxSZXF1ZXN0NDI0MjQ5MzI4 4103 keep attrs in reset_index 23738400 closed 0     7 2020-05-28T05:00:50Z 2020-06-05T19:42:54Z 2020-06-05T19:39:10Z CONTRIBUTOR   0 pydata/xarray/pulls/4103

Modifies the code in reset_index to keep attributes when converting an indexing coordinate to non indexing coordinate. I have added tests for single index for both dataarray and dataset. Not sure if both are needed as they end up calling the same base function.

Regarding multiindex, I think it is not possible to keep the metadata as it is removed when creating the multiindex/stacking.

  • [x] Closes #4101
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4103/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables