issues: 625942676

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
625942676 MDExOlB1bGxSZXF1ZXN0NDI0MDQ4Mzg3 4099 Allow non-unique and non-monotonic coordinates in get_clean_interp_index and polyfit 20629530 closed 0     0 2020-05-27T18:48:58Z 2020-06-05T15:46:00Z 2020-06-05T15:46:00Z CONTRIBUTOR   0 pydata/xarray/pulls/4099
  • [ ] Closes #xxxx
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

Pull #3733 added da.polyfit and xr.polyval and is using xr.core.missing.get_clean_interp_index in order to get the fitting coordinate. However, this method is stricter than what polyfit needs: as in numpy.polyfit, non-unique and non-monotonic indexes are acceptable. This PR adds a strict keyword argument to get_clean_interp_index so we can skip the uniqueness and monotony tests.

ds.polyfit and xr.polyval were modified to use that keyword. I only added tests for get_clean_interp_index, could add more for polyfit if requested.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4099/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables