issues: 609907735

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
609907735 MDExOlB1bGxSZXF1ZXN0NDExNDIxODIz 4017 Combining attrs of member DataArrays of Datasets 3958036 closed 0     0 2020-04-30T12:23:10Z 2021-05-05T16:37:25Z 2021-05-05T16:37:25Z CONTRIBUTOR   0 pydata/xarray/pulls/4017

While looking at #4009, I noticed that the combine_attrs kwarg to concat or merge only affects the global attrs of the Dataset, not the attrs of DataArray or Variable members of the Datasets being combined. I think this is a bug.

So far this PR adds tests that reproduce the issue in #4009, and the issue described above. Fixing should be fairly simple: for #4009 pass combine_attrs="drop" to combine_by_coords and combine_nested in open_mfdataset; for this issue insert the combine_attrs handling in an appropriate place - possibly in merge.unique_variable. I'll update with fixes when I get a chance.

  • [ ] Closes #4009
  • [x] Tests added
  • [ ] Passes isort -rc . && black . && mypy . && flake8
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4017/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables