home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 603594157

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
603594157 MDU6SXNzdWU2MDM1OTQxNTc= 3987 failing distributed tests on upstream-dev 14808389 closed 0     0 2020-04-20T23:18:08Z 2020-04-21T12:53:45Z 2020-04-21T12:53:45Z MEMBER      

Since dask/distributed#3706 gen_cluster requires functions decorated with it to be coroutines. We use it twice in test_distributed.py: on test_async and on test_serializable_locks, which both are pre-3.5 style coroutines (yield / yield from instead of async / await) but not marked as such (I'm not sure what pytest does with coroutines).

I think this should be a pretty strait-forward fix: replace def with async def and yield / yield from with await.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3987/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed 13221727 issue

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 0 rows from issue in issue_comments
Powered by Datasette · Queries took 0.712ms · About: xarray-datasette