issues: 601364609

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
601364609 MDExOlB1bGxSZXF1ZXN0NDA0NjM0Mjk0 3979 full_like: error on non-scalar fill_value 13662783 closed 0     2 2020-04-16T19:18:50Z 2020-04-24T07:15:49Z 2020-04-24T07:15:44Z CONTRIBUTOR   0 pydata/xarray/pulls/3979
  • [x] Closes #3977
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

@dcherian's suggestion in #3977 seemed straightforward enough for me to have a try.

Two thoughts: * does the np.isscalar check belong in the outer function, or the inner? The inner function is only called by the outer one. * Bugfix or arguably a breaking change?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3979/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables