home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 589583977

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
589583977 MDU6SXNzdWU1ODk1ODM5Nzc= 3908 check index invariants in test_dataset, test_dataarray 2448579 closed 0     5 2020-03-28T14:07:17Z 2020-10-13T04:03:58Z 2020-10-13T04:03:58Z MEMBER      

There are a large number of tests in test_dataarray.py and test_dataset.py that use the assert actual.equals(expected) pattern.

We should switch these to be assert_equal(actual, expected) so that we run the invariant checks:

https://github.com/pydata/xarray/blob/acf7d4157ca44f05c85a92d1b914b68738988773/xarray/tests/init.py#L150-L154

Seems like an easy use of regexes for someone that knows them (i.e. not me ;))

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3908/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed 13221727 issue

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 5 rows from issue in issue_comments
Powered by Datasette · Queries took 0.535ms · About: xarray-datasette