issues: 541448514

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
541448514 MDExOlB1bGxSZXF1ZXN0MzU2MDg0NDg3 3652 Use encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode 6628425 closed 0     0 2019-12-22T13:05:18Z 2020-01-15T15:23:41Z 2020-01-15T15:22:30Z MEMBER   0 pydata/xarray/pulls/3652

This uses encoding['dtype'] over data.dtype when possible within CFMaskCoder.encode to decide what type to cast encoding['missing_value'] or encoding['_FillValue'] to; this is one way to fix #3624. Another possible way would be to ensure the times have the proper dtype coming from CFDatetimeCoder.encode. I'm not sure what is the preferred solution.

cc: @andersy005, @spencerahill

  • [x] Closes #3624
  • [x] Tests added
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3652/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables