issues: 533996523

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
533996523 MDExOlB1bGxSZXF1ZXN0MzQ5OTc0NjUz 3601 Fix contourf set under 3958036 closed 0     5 2019-12-06T13:47:37Z 2020-02-24T20:20:09Z 2020-02-24T20:20:08Z CONTRIBUTOR   0 pydata/xarray/pulls/3601

Copies the cmap._rgba_bad, cmap._rgba_under, and cmap._rgba_over values to new_cmap, in case they have been set to non-default values. Allows the user to customize plots more by using matplotlib methods on a cmap before passing as an argument to xarray's plotting methods. Previously these settings were overridden by defaults when creating the cmap actually used to make the plot.

I'm not a fan of copying attributes one-by-one like this, but I guess this is an issue with matplotlib's API, unless there's a nicer way to convert a cmap to a discrete cmap than mpl.colors.from_levels_and_colors().

  • [x] Closes #3590
  • [x] Tests added
  • [x] Passes black . && mypy . && flake8
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3601/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables