issues: 522562906

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
522562906 MDExOlB1bGxSZXF1ZXN0MzQwNzQwNjE2 3529 Deprecation warning in _replace_vars_and_dims 5635139 closed 0     3 2019-11-14T01:09:34Z 2021-05-13T22:01:45Z 2021-05-13T22:01:45Z MEMBER   0 pydata/xarray/pulls/3529

& removed internal usages

  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

I needed to pass indexes=None from some of the existing methods that were using the deprecated method. I spent some time debugging but couldn't work out the causality. I added TODOs as part of the index work.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3529/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables