issues: 497416198

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
497416198 MDExOlB1bGxSZXF1ZXN0MzIwNTUxODg0 3336 Provide better error message when dimension name matches argument 2818208 open 0     7 2019-09-24T02:16:05Z 2023-12-02T02:53:11Z   CONTRIBUTOR   0 pydata/xarray/pulls/3336

WIP PR for https://github.com/pydata/xarray/issues/3324. Since either_dict_or_kwargs is called 57 times, I don't want to modify every function call without a preliminary review. My main question is if using locals() at the top of each function is considered acceptable. Of course, if locals() is called after some local variables are created, this code could raise an error when no conflict exists. But explicitly passing in the function argument names in all 57 functions seems brittle. I'd appreciate any thoughts on the PR before I modify all the functions and write some tests.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3336/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables