issues: 448330247

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
448330247 MDExOlB1bGxSZXF1ZXN0MjgyMTQwNTM3 2989 Add strftime() to datetime accessor with cftimeindex and dask support 6145107 closed 0     4 2019-05-24T19:52:42Z 2019-06-01T07:51:43Z 2019-06-01T07:51:17Z CONTRIBUTOR   0 pydata/xarray/pulls/2989
  • [x] Closes #2090
  • [x] Tests added
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
  • [x] Add further examples to User Guide Docs

Building on #2144, I added dask support and returning the appropriate object type.

The two initial commits show alternate approach to handling cftime values. Either adding strftime to cftimeindex and accessing that way (commit 5de4db1) or just rolling the loop within the datetime accessor and not touching cftimeindex at all ( 51239c9). can revert commit 5de4db1 if its preferred to not touch cftimeindex for any reason.

Can clean up docstrings and minor formatting after some input on the implementation details.
Is there a vectorized or better method for the cftime values? List comprehension was the best I could come up with, borrowing from similar logic elsewhere in the code.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2989/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables