issues: 443157666

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
443157666 MDExOlB1bGxSZXF1ZXN0Mjc4MDg4MTA1 2956 Picking up #1118: Do not convert subclasses of `ndarray` unless required 14808389 closed 0     17 2019-05-12T23:12:43Z 2019-12-25T14:14:00Z 2019-12-25T14:11:45Z MEMBER   0 pydata/xarray/pulls/2956

This picks up the work done in #1118, plus converting the unittest based tests to pytest (since that seems to be used in the other tests).

closes #1118

Some of the suggestions there are not implemented yet: * the disabling of bottleneck if a ndarray subclass is used * testing for operations like xarray.concat. This does not work with any of the unit libraries (at least, pint, astropy.units, unyt and quantities don't support it yet). * testing with other unit libraries that use subclasses (e.g. astropy.units or unyt) * renaming the test file to test_units_subclass.py * fix indexing (NumpyIndexingAdapter)

The requirements files for CI changed since then, so maybe more than the two right now need the quantities entry.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2956/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables