issues: 424262546

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
424262546 MDExOlB1bGxSZXF1ZXN0MjYzNjU0NzQ0 2843 Allow passing _FillValue=False in encoding for vlen str variables. 22566757 closed 0     2 2019-03-22T15:20:27Z 2019-03-30T14:04:30Z 2019-03-30T14:04:13Z CONTRIBUTOR   0 pydata/xarray/pulls/2843

The documentation seems to imply that passing _FillValue=False in the encoding works to set no fill value for any value. These changes to netCDF4_.py and h5netcdf_.py seem to allow this for variables that are vlen strings (dtype str rather than "S1"): I have used the code-path in netCDF4_.py in real code and know that it at least allows the save to complete.

Allowing _FillValue=False makes it easier to explicitly exclude _FillValue from being written for coordinate variables, which some CF-compliance checkers complain about.

  • [ ] Closes #xxxx
  • [X] Tests added
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2843/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables