home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 417356439

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
417356439 MDU6SXNzdWU0MTczNTY0Mzk= 2801 NaN-sized chunks 6213168 open 0     2 2019-03-05T15:30:14Z 2021-04-24T02:41:34Z   MEMBER      

It would be nice to have support for NaN-sized dask chunks, e.g. x[x > 2]. There are two problems:

  1. x[x > 2] silently resolves the dask graph. It definitely shouldn't. There needs to be some discussion on what needs to happen to indices on the NaN-sized dimension; I can think of 3 options:
  2. silently drop any index that would become undefined
  3. drop any index that would become undefined and issue a warning
  4. hard crash if there is any index that would become undefined
  5. redesign IndexVariable so that it can contain dask data (probably much more complicated than the 3 above). The above design decision is anyway for when there is an index; dims without indices should just work.

  6. This crashes: ```>>> a = xarray.DataArray([1, 2, 3, 4]).chunk(2)

    xarray.DataArray(a.data[a.data > 2]).compute()

ValueError: replacement data must match the Variable's shape ``` I didn't investigate but I suspect it should be trivial to fix. I'm not sure why there is a check at all? Any such health check should be in dask only IMHO.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2801/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 issue

Links from other tables

  • 1 row from issues_id in issues_labels
  • 2 rows from issue in issue_comments
Powered by Datasette · Queries took 1.328ms · About: xarray-datasette