issues: 408645889

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
408645889 MDU6SXNzdWU0MDg2NDU4ODk= 2760 docs clarity for notnull() etc 12852539 closed 0     2 2019-02-11T06:09:00Z 2020-11-30T15:10:57Z 2020-11-30T15:10:57Z NONE      

Some problems with the documentation for xarray.DataArray.notnull:

  1. The current stable (v0.11.3) docs appear broken and provide no prose explanation of the function, input parameters, or return value.
  2. The previous (v0.9.6) docs describe the function as a replacement for numpy.isfinite / -numpy.isnan. Which is it? (isfinite and isnan are not equivalent in numpy; and from the code I suspect it may invoke pandas.notnull instead.)
  3. The docs unhelpfully give the signature as DataArray.notnull(*args, **kwargs), but I think this function is actually an instance method that takes no positional nor keyword arguments.

It seems like the function is monkey-patched (duck-punched?) onto the class rather than explicitly defined anywhere, so it isn't immediately obvious to me where to best clarify this documentation.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2760/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables