issues: 396084601

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
396084601 MDExOlB1bGxSZXF1ZXN0MjQyMzg2MDIw 2651 Convert ref_date to UTC in encode_cf_datetime 6628425 closed 0     2 2019-01-04T22:10:21Z 2019-01-15T18:55:50Z 2019-01-05T19:06:55Z MEMBER   0 pydata/xarray/pulls/2651
  • [x] Closes #2649
  • [x] Tests added
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

I think this should be an appropriate fix for #2649, but I'd appreciate input from those who are more experienced dealing with timezones in NumPy/pandas.

My understanding is that NumPy dates are stored as UTC and do not carry any timezone information. Therefore converting the ref_date with tz_convert(None) here, which converts it to UTC and removes the timezone information, should be appropriate for encoding.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2651/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables