issues: 394017899

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
394017899 MDExOlB1bGxSZXF1ZXN0MjQwODcyMDM1 2633 Fix dayofweek and dayofyear attributes from dates generated by cftime_range 6628425 closed 0     3 2018-12-25T12:57:13Z 2018-12-28T22:55:55Z 2018-12-28T19:04:50Z MEMBER   0 pydata/xarray/pulls/2633
  • [x] Tests added

It turns out there was a remaining bug in cftime (https://github.com/Unidata/cftime/issues/106) that impacted the results of the dayofwk and dayofyr attributes of cftime objects generated by their replace method, which we use when parsing dates from strings, and in some offset arithmetic.

A workaround is to add a dayofwk=-1 argument to each replace call where the dayofwk or dayofyr would be expected to change. I've fixed this bug upstream in cftime (https://github.com/Unidata/cftime/pull/108), but it will only be available in a future version. Would it be appropriate to use this workaround in xarray?

This would fix this doc page for instance:

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2633/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables