issues: 387924616

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
387924616 MDExOlB1bGxSZXF1ZXN0MjM2MzA2MjA0 2593 CFTimeIndex Resampling 8708062 closed 0     39 2018-12-05T20:08:06Z 2019-02-03T03:21:29Z 2019-02-03T03:21:14Z CONTRIBUTOR   0 pydata/xarray/pulls/2593

I would appreciate some feedback on why this implementation for CFTimeIndex resampling doesn't match pandas' output 100%.

  • [x] Tentative attempt at addressing #2191 (resampling CFTimeIndex). Downsampling produces results that match pandas' results in all the tests done thus far. However, upsampling has trouble assigning the right values to the right bins.
  • [x] Tests (test_cftimeindex_resample.py) created for standard calendars but not for non-standard calendars (360 days etc.). Contents from test_cftimeindex_resample.py will be inserted into test_dataarray.py and test_cftimeindex_resample.py will be deleted once resampling implementation is finalized. Files found in the tests/temp folder is meant to highlight resampling discrepancies between pandas and this implementaion. Both the files and the folder will be removed once resampling implementation is finalized.
  • [x] Not fully documented. Docstrings have yet to be added to resample_cftime.py. There were no doctrings from https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py (which is where the codes were ported from) that could be conveniently copied.
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2593/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables