issues: 374748365

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
374748365 MDExOlB1bGxSZXF1ZXN0MjI2MzYzMTc5 2522 Remove tests where results change in cftime 1.0.2.1 6628425 closed 0     1 2018-10-28T12:25:38Z 2018-10-30T01:58:15Z 2018-10-30T01:00:43Z MEMBER   0 pydata/xarray/pulls/2522
  • [x] Closes #2521 (remove if there is no corresponding issue, which should only be the case for minor changes)

cftime version 1.0.2.1 (currently only installed on Windows, because it hasn't appeared on conda-forge yet) includes some changes that improve the precision of datetime arithmetic, which causes some results of infer_datetime_units to change. These changes aren't really a concern, because it doesn't impact our ability to round-trip dates; it just changes the units dates are encoded with in some cases. For that reason I've just deleted the tests where the answers change across versions.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2522/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables