issues: 371514413

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
371514413 MDExOlB1bGxSZXF1ZXN0MjIzOTQzNTcz 2492 ENH: Detect the GRIB files by the filename extension and suggest engine. 226037 closed 0     11 2018-10-18T12:50:13Z 2018-10-25T20:57:38Z 2018-10-22T15:26:14Z MEMBER   0 pydata/xarray/pulls/2492

_get_default_engine chooses the engine suitable to open the path, ATM it only detects URL's. In this PR I propose to also detect GRIB files by the extension and suggest to the user which engine to use.

Updated: The whole engine detection strategy looked a bit fragile as the .gz extension was recognised outside of _get_default_engine and the nested ifs and try / except blocks make the code poorly readable. I added a bit of a refactor in this area.

  • ~~Closes xxxx~~
  • [x] Tests added
  • ~~Fully documented, including whats-new.rst for all changes and api.rst for new API.~~ No change to document.
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2492/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables